Skip to content

Comments

Add Deploy-Hub helper script#2008

Merged
flanakin merged 3 commits intodevfrom
flanakin/deploy-hub-script
Feb 24, 2026
Merged

Add Deploy-Hub helper script#2008
flanakin merged 3 commits intodevfrom
flanakin/deploy-hub-script

Conversation

@flanakin
Copy link
Collaborator

🛠️ Description

Add Deploy-Hub.ps1, a wrapper around Deploy-Toolkit that simplifies FinOps hub deployments for local testing by providing scenario-based flags instead of requiring you to remember all the Bicep parameter names.

  • Uses {initials}-{name} naming convention (initials from git config user.name, name defaults to adx)
  • Supports ADX (default), storage-only (-StorageOnly), and Fabric (-Fabric) deployment scenarios
  • Includes -Remove mode to list or delete test resource groups
  • Documented in src/scripts/README.md

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Internal dev docs in src (required for dev)

Copilot AI review requested due to automatic review settings February 17, 2026 06:31
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review 👀 PR that is ready to be reviewed label Feb 17, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot added the Skill: DevOps GitHub setup and automation label Feb 17, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new PowerShell helper to streamline local FinOps hub deployments by wrapping Deploy-Toolkit with scenario-based flags, and documents the new workflow in the scripts README.

Changes:

  • Added src/scripts/Deploy-Hub.ps1 helper wrapper for ADX (default), storage-only, and Fabric scenarios, plus a -Remove cleanup mode.
  • Updated src/scripts/README.md to document Deploy-Hub usage and examples.
  • Minor markdown cleanup in src/scripts/README.md (formatting consistency in later sections).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/scripts/Deploy-Hub.ps1 New wrapper script around Deploy-Toolkit to simplify local FinOps hub deployments and test-environment cleanup.
src/scripts/README.md Adds a new Deploy-Hub section and updates the table of contents; small markdown formatting fixes.

@flanakin flanakin added this to the v14 milestone Feb 23, 2026
- Honor -WhatIf in Remove mode by passing -WhatIf:$WhatIf to Remove-AzResourceGroup
- Fix $groups null check using -not $groups instead of .Count

🤖 Generated with [Claude Code](https://claude.ai/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@flanakin flanakin requested a review from MSBrett as a code owner February 24, 2026 11:59
@flanakin
Copy link
Collaborator Author

🤖 [AI][Claude] PR Update Summary

Addressed: 3 thread(s)

  • ✅ Implemented: 2
  • 🤔 Needs discussion: 1

Changes:

  • Passed -WhatIf:$WhatIf to Remove-AzResourceGroup in Remove mode, matching the Deploy-Toolkit pattern
  • Fixed $groups.Count to use -not $groups for reliable null/empty check
  • Pushed back on changelog entry (internal dev script, not user-facing)

@flanakin flanakin enabled auto-merge (squash) February 24, 2026 12:02
@flanakin flanakin merged commit ff23be5 into dev Feb 24, 2026
4 checks passed
@flanakin flanakin deleted the flanakin/deploy-hub-script branch February 24, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Review 👀 PR that is ready to be reviewed Skill: DevOps GitHub setup and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants